Allow interactions to be filtered by contact ID #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgsunkel
changed the title
Co-authored-by: Dean Elliott <[email protected]>
cgsunkel
force-pushed
the
chore/allow-filtering-by-contact-id-in-interaction-search
branch
from
31155a1 to
cec83d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5487 +/- ##
=======================================
Coverage 96.35% 96.36%
=======================================
Files 953 953
Lines 22523 22524 +1
Branches 2023 2023
=======================================
+ Hits 21703 21706 +3
+ Misses 667 666 -1
+ Partials 153 152 -1 ☔ View full report in Codecov by Sentry. |
DeanElliott96
approved these changes
Jun 14, 2024
elcct
approved these changes
Jun 14, 2024
cgsunkel
deleted the
chore/allow-filtering-by-contact-id-in-interaction-search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As part of an upcoming piece of work we need to return a list of interactions for a specific contact. This is now possible.
Checklist
Has this branch been rebased on top of the current
mainbranch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yamlis maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.